D12743: Unit tests fixes

Milian Wolff noreply at phabricator.kde.org
Mon May 7 19:17:47 UTC 2018

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.


> test_pluginenabling.cpp:138
>      // logic in kdevelop different from  KPluginMetaData::isEnabledByDefault(), here defaults to true
> -    const auto enabledByDefaultValue = pluginInfo.rawData()["KPlugin"].toObject()["EnabledByDefault"];
> +    auto kPlugin = pluginInfo.rawData()["KPlugin"].toObject();
> +    const auto enabledByDefaultValue = kPlugin["EnabledByDefault"];

this doesn't change anything from a functionality point of view. Please use valgrind or similar to inspect the crash

> test_gdb.cpp:679
>      qDebug() << "adding breakpoint";
> -    KDevelop::Breakpoint *b = breakpoints()->addCodeBreakpoint(QUrl::fromLocalFile(fileName), 25);
> +    KDevelop::Breakpoint *b = breakpoints()->addCodeBreakpoint(QUrl::fromLocalFile(fileName), 30); // ++i;
>      QTest::qWait(500);

these all sound fine, but please make this a separate commit

  R32 KDevelop


To: arrowdodger, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180507/567254ac/attachment.html>

More information about the KDevelop-devel mailing list