D11601: Properly save state of KTextEditor Views

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  doh :)
  
  some minor nits, otherwise lgtm. please cleanup and then feel free to push
  
  also, I'd prefer if we don't leak the implementation detail of the apparently useless `QSet` of flags, since it's always going to be empty anyways

INLINE COMMENTS

> textdocument.h:114
> +
> +    void readSessionConfig(KConfigGroup & config, const QSet<QString> & flags) override;
> +    void writeSessionConfig(KConfigGroup & config, const QSet<QString> & flags) override;

remove spaces before &, also below

> view.h:24
>  #include <QMetaType>
> +#include <QList>
> +#include <QSet>

qlist include shouldn't be required?

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11601

To: kfunk, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180323/a8255fe5/attachment.html>