D11136: Make sure we use the same compiler settings as the project is by default

Milian Wolff noreply at phabricator.kde.org
Thu Mar 8 22:13:17 UTC 2018


mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  three minor nits, otherwise lgtm

INLINE COMMENTS

> custombuildsystemplugin.cpp:202
> +}
> +
> +

remove the second empty line

> compilerprovider.cpp:169
> +        [pathString](const CompilerPointer& compiler) { return compiler->path() == pathString; });
> +    if (it != m_compilers.end())
> +    {

join next line

> qmakemanager.cpp:521
> +}
> +
> +

remove second empty line

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11136

To: apol, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180308/490ea58f/attachment-0001.html>


More information about the KDevelop-devel mailing list