D11136: Make sure we use the same compiler settings as the project is by default

[Milian Wolff]

mwolff added a comment.


  one minor nit (the qGetEnv), otherwise lgtm now

INLINE COMMENTS

> cmakemanager.cpp:320
> +            KDevelop::ICore::self()->projectController()->projectConfigurationChanged(project);
>              KDevelop::ICore::self()->projectController()->reparseProject(project, true);
>          });

thinking ahead: we should think about moving this reparse to a central place, connected to the projectConfigurationChanged signal above

> custommakemanager.cpp:329
> +{
> +    return KDevelop::Path(QFile::encodeName(qgetenv("CXX")));
> +}

return empty

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D11136

To: apol, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180308/3b8c8a75/attachment.html>