D11081: UI improvements for problem reporter
Anton Anikin
noreply at phabricator.kde.org
Tue Mar 6 04:00:16 UTC 2018
antonanikin created this revision.
antonanikin added a reviewer: KDevelop.
antonanikin requested review of this revision.
REVISION SUMMARY
The patch provides new UI approach for problem reporter tool view. Old (current) version hides some UI elements for selected problem model if the correspondent feature is not supported, for example "Show imports" button for cppcheck model. This leads to inconsistent UI during model changing - tool view layout also changed and non-disabled UI elements are moved ("jumps") inside the form.
New version uses disabling unsupported UI elements instead hiding, which blocks layout changing. Also new widget is used for "Scope" and "Grouping" buttons - now this buttons has fixed size compliant to menu action with maximum text width. This done also for blocking widgets resize during UI operations. New menu widget also fixes tooltips showing, which is broken for current version. QSignalMapper is dropped during it'snow deprecated class (since Qt 5.10).
New version also allows us to add mechanism for temporarily blocking (disabling) some widgets for example "Full Update" button when model reset is started. This now done with using ProblemModel::featuresChanged signal which emitted by cppcheck plugin at start and at the end of analysis.
REPOSITORY
R32 KDevelop
BRANCH
problemsview
REVISION DETAIL
https://phabricator.kde.org/D11081
AFFECTED FILES
kdevplatform/shell/problemmodel.cpp
kdevplatform/shell/problemmodel.h
plugins/cppcheck/problemmodel.cpp
plugins/problemreporter/CMakeLists.txt
plugins/problemreporter/actionmenu.cpp
plugins/problemreporter/actionmenu.h
plugins/problemreporter/problemsview.cpp
plugins/problemreporter/problemsview.h
plugins/problemreporter/tests/CMakeLists.txt
To: antonanikin, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180306/c01a8f3a/attachment-0001.html>
More information about the KDevelop-devel
mailing list