D10196: Enable connection of Debuggers to DrKonqi

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  minor style stuff, but otherwise lgtm - at least I don't have any concrete improvement suggestions. if it works for you, let's go for it!
  
  one idea though: can we somehow improve this step: `enable the DrKonqi debug button`? Like, automatically enable it while KDevelop is running or something like that? Though not every KDevelop user may want to debug KDE apps, still... Could be done I guess?

INLINE COMMENTS

> midebuggerplugin.cpp:104
> +private:
> +    QDBusInterface dbusinterface;
> +    QString m_name;

m_dbusInterface

> midebuggerplugin.cpp:106
> +    QString m_name;
> +    bool valid;
> +};

m_valid

REPOSITORY
  R32 KDevelop

BRANCH
  dbusdrkonqi

REVISION DETAIL
  https://phabricator.kde.org/D10196

To: croick, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180304/aa628973/attachment.html>