D13387: Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes.
Gleb Popov
noreply at phabricator.kde.org
Wed Jun 6 19:32:49 UTC 2018
arrowdodger created this revision.
arrowdodger added a reviewer: KDevelop.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
arrowdodger requested review of this revision.
REVISION SUMMARY
Without marking these classes as exported, `dynamic_cast<>`'s on them fail. This was causing test_problemstore to fail on FreeBSD.
This problem can be made visible if you move ProblemStoreNode constructor into a .cpp belonging to KDevPlatformShell library. The `test_problemstore` would fail to link then, due to unresolved references to "typeinfo".
TEST PLAN
test_problemstore now passes on FreeBSD
REPOSITORY
R32 KDevelop
BRANCH
problemstorenode_export
REVISION DETAIL
https://phabricator.kde.org/D13387
AFFECTED FILES
kdevplatform/shell/problemstorenode.h
To: arrowdodger, #kdevelop
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180606/df0a7f62/attachment.html>
More information about the KDevelop-devel
mailing list