D14484: Skip attach tests on FreeBSD due to bug in GDB.

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> arrowd wrote in test_gdb.cpp:982
> Was just following what `SKIP_IF_ATTACH_FORBIDDEN();` does.

... which though inside `KDevMI::isAttachForbidden(...)` calls `QTest::qSkip(...)` :)
Was also initially confused by the name of `KDevMI::isAttachForbidden(...)` but it is actually from the testhelper part. Someone(tm) should improve that for some explicit namespace or method name...

For the text, i would propose to be more explicit "GDB on FreeBSD produces an unexpected error message, on which KDevelop chokes") and perhaps leave the link to the bug report only as normal comment in the code, not sure how nice multi-line skip messages are in the output?

Please note the actual error directly in the sources, so one does not have to hunt for the commit message or open a browser to read the bug report.

Long nitpicking, let me give a short example how I personally would prefer it: :)

  #ifdef Q_OS_FREEBSD
      // Despite successful attach GDB MI spits out a error message "Can't allocate registers". This gets caught by KDevMI layer and gets interpreted as error.
      // PR: https://sourceware.org/bugzilla/show_bug.cgi?id=23464
      QSKIP("GDB on FreeBSD produces an unexpected error message, on which KDevelop chokes");
  #endif

That should serve the purpose of keeping the test log short. And allow any reader/editor of the code to directly see what the issue is. What do you think?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14484

To: arrowd, #kdevelop
Cc: kossebau, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180730/ed4e298f/attachment-0001.html>