D14470: Fix two tests in test_gdb.

Gleb Popov noreply at phabricator.kde.org
Sun Jul 29 20:54:21 BST 2018


arrowd added a comment.


  RE line 960.
  
  What does `QCOMPARE(stackModel->rowCount(), 4);` actually check? I added printing for `stackModel` and running test multiple times gives me different results:
  
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#1 at main"
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#2 at base_block_alloc"
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#3 at check_and_init_mutex"
  
  
  
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#1 at main"
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#2 at malloc_mutex_unlock"
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#3 at __pthread_mutex_trylock"
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#4 at thread_start"
  
  
  
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#1 at main"
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#2 at arena_stats_init"
    QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#3 at malloc_mutex_trylock_final"
  
  This looks pretty system-specific, so I decided to just check that we have more that 2 rows, because the test uses first and second row for checks.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14470

To: arrowd, #kdevelop
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180729/aba07fe0/attachment.html>


More information about the KDevelop-devel mailing list