D14288: Initial version of Clazy analyzer plugin

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Jul 27 14:22:11 BST 2018


kossebau added inline comments.

INLINE COMMENTS

> globalconfigpage.cpp:96
> +{
> +    return QIcon::fromTheme(QStringLiteral("kdevelop"));
> +}

Please use the same icon across all the places. This helps to more quickly find the config pages for the tool.

Sadly clazy has no own icon yet to use here, filed that now as bug https://bugs.kde.org/show_bug.cgi?id=396904 :)

Guess "dialog-ok" might be fine for now, no other plugin uses that as visual id yet :)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14288

To: antonanikin, #kdevelop
Cc: kossebau, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180727/42739615/attachment-0001.html>


More information about the KDevelop-devel mailing list