D14313: Fix clangsupport on FreeBSD.

Pino Toscano noreply at phabricator.kde.org
Tue Jul 24 18:52:46 BST 2018


pino requested changes to this revision.
pino added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> arrowd wrote in clangsupport.cpp:181
> This would make the code a bit uglier at the cost of a bit prettier message. Can do, if you insist.

I don't see how `QFile::exists(builtinDir + QLatin1String("/") + headerToCheck)` would be uglier (which is something highly subjective).
So yes, please change.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14313

To: arrowd, #kdevelop, pino
Cc: pino, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180724/fac65156/attachment.html>


More information about the KDevelop-devel mailing list