D14288: Initial version of Clazy analyzer plugin
Anton Anikin
noreply at phabricator.kde.org
Mon Jul 23 13:28:00 BST 2018
antonanikin added a comment.
In D14288#296167 <https://phabricator.kde.org/D14288#296167>, @kossebau wrote:
> Oh, and then another code-style request, while at it :)
>
> Could you make any members private, unless they really need to be accessable by subclasses?
>
> And also split member variables off into an own section with own "private:" at the end of the class declaration, separate from any method declarations?
> That should follow existing KDevelop conventions as well.
>
> Motivation would be (besides consistency):
>
> - by default only expose what really needs to be exposed
> - keeping member variables grouped helps to more quickly understand the class design
Ok, will be fixed in next revision(s)
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D14288
To: antonanikin, #kdevelop
Cc: kossebau, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180723/fbc8930a/attachment.html>
More information about the KDevelop-devel
mailing list