D14277: qmljs: Make string code more robust by checking isEmpty over isNull

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  In all cases empty non-null QStrings match the tested cases as well, so the
  code better catches those QString variants as well, not just empty null
  ones.
  Makes the code looking less fragile (no special handling of null QStrings)

TEST PLAN
  Tests work/fail as before ;)

REPOSITORY
  R32 KDevelop

BRANCH
  changesomeisnull

REVISION DETAIL
  https://phabricator.kde.org/D14277

AFFECTED FILES
  plugins/qmljs/duchain/cache.cpp
  plugins/qmljs/duchain/declarationbuilder.cpp
  plugins/qmljs/duchain/frameworks/nodejs.cpp
  plugins/qmljs/duchain/helper.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180722/dd157396/attachment.html>