D13900: Disable class-memaccess compiler warnings where not wanted

Anton Anikin noreply at phabricator.kde.org
Thu Jul 19 07:24:26 BST 2018


antonanikin added a comment.


  Hi, Friedrich. Sorry, but this commit completely broke my KDevelop :) Now it always crashes on start.
  
  I think this patch is wrong, because instead of hiding compiler warnings you also disable `memset()` calls. Patched parts should be something like this:
  
    #ifndef QT_NO_DEBUG
    #if defined(__GNUC__) && !defined(__INTEL_COMPILER) && (((__GNUC__ * 100) + __GNUC_MINOR__) >= 800)
    #pragma GCC diagnostic push
    #pragma GCC diagnostic ignored "-Wclass-memaccess"
    #endif
    
          memset(item, 0, size); //For debugging, so we notice the data is wrong
    
    #if defined(__GNUC__) && !defined(__INTEL_COMPILER) && (((__GNUC__ * 100) + __GNUC_MINOR__) >= 800)
    #pragma GCC diagnostic pop
    #endif
    #endif

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D13900

To: kossebau, #kdevelop, kfunk
Cc: antonanikin, aaronpuchert, kfunk, kdevelop-devel, antismap, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180719/dd2be353/attachment.html>


More information about the KDevelop-devel mailing list