D10122: Check declareVariable type exist
Milian Wolff
noreply at phabricator.kde.org
Tue Jan 30 15:26:59 UTC 2018
mwolff added a comment.
this looks bogus, why do you not return a type? shouldn't you rather set some type higher up?
overall, this begs for a unit test and for a clearer commit message that explains _why_ you are doing this, not only _what_ you are doing.
REPOSITORY
R59 KDevelop Go
REVISION DETAIL
https://phabricator.kde.org/D10122
To: huguesmorisset
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180130/2684c603/attachment.html>
More information about the KDevelop-devel
mailing list