D9881: Replace deprecated QSignalMapper by lambda expressions
Christoph Roick
noreply at phabricator.kde.org
Sun Jan 14 22:03:53 UTC 2018
croick created this revision.
croick added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
croick requested review of this revision.
REVISION SUMMARY
- QSignalMapper can mostly be replaced using straightforward lambdas, reducing the code size
- exception: connecting to a DBus signal is only possible by macros, requiring a proxy class which remembers the sender
TEST PLAN
- switch scope and arrangement of problems in ProblemView
- create an application using the AppWizard
- add a compiler
- switch representation of register variables
- add code to an existing file using a file template
- open a file with an external application
- switch to header/source file using the context menu action
- track changes of a variable in the debugger
- status bar seems to work
- untested: runcontroller, DrKonqi debugging
REPOSITORY
R32 KDevelop
BRANCH
deprSignalMapper
REVISION DETAIL
https://phabricator.kde.org/D9881
AFFECTED FILES
kdevplatform/debugger/variable/variabletooltip.cpp
kdevplatform/debugger/variable/variablewidget.cpp
kdevplatform/debugger/variable/variablewidget.h
kdevplatform/shell/problemmodel.h
kdevplatform/shell/runcontroller.cpp
kdevplatform/shell/statusbar.cpp
kdevplatform/shell/statusbar.h
plugins/appwizard/appwizarddialog.cpp
plugins/appwizard/appwizarddialog.h
plugins/custom-definesandincludes/compilerprovider/widget/compilerswidget.cpp
plugins/custom-definesandincludes/compilerprovider/widget/compilerswidget.h
plugins/debuggercommon/midebuggerplugin.cpp
plugins/debuggercommon/midebuggerplugin.h
plugins/debuggercommon/registers/registersview.cpp
plugins/debuggercommon/registers/registersview.h
plugins/filetemplates/outputpage.cpp
plugins/openwith/openwithplugin.cpp
plugins/openwith/openwithplugin.h
plugins/problemreporter/problemsview.cpp
plugins/switchtobuddy/switchtobuddyplugin.cpp
plugins/switchtobuddy/switchtobuddyplugin.h
To: croick, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180114/5aa4ca9a/attachment.html>
More information about the KDevelop-devel
mailing list