D9809: work around bug in kLineEdit
noreply at phabricator.kde.org
Thu Jan 11 16:06:07 UTC 2018
dweatherill added a comment.
In https://phabricator.kde.org/D9809#189484, @mwolff wrote:
> So just remove the assert - instead return early when indexes.isEmpty(). That way we don't need to mess with the signal blocker and the code behaves as intended. And you remove code instead of adding more.
I agree that fixes the crash, in fact that was the first fix I tried.
However, compilerEdited is still being spuriously called, and the underlying cause is the kLineEdit bug.
When that bug gets fixed, we could do a version check on KF5 libs and #ifdef out this fix. In that case, I think it's clearer to block the signals... but I am happy to change it if that is the preferred solution
To: dweatherill, #kdevelop, apol, mwolff
Cc: mwolff, anthonyfieroni, kdevelop-devel, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel