D9772: Cache ProblemPointers per translation unit

Kevin Funk noreply at phabricator.kde.org
Wed Jan 10 10:28:05 UTC 2018


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  LGTM.
  
  To 5.2 branch please.

INLINE COMMENTS

> parsesession.h:83
> +    // cached diagnostics
> +    QVector<KDevelop::ProblemPointer> m_diagnostics;
>  };

`m_diagnostics` -> `m_diagnosticsCache` for readability?

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9772

To: mwolff, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180110/866ff4ea/attachment-0001.html>


More information about the KDevelop-devel mailing list