D9723: Unbreak most of the clang codecompletion test by passing file contents
Milian Wolff
noreply at phabricator.kde.org
Mon Jan 8 00:01:46 UTC 2018
mwolff created this revision.
mwolff added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
mwolff requested review of this revision.
REVISION SUMMARY
Since the introduction of the CXUnsavedFile for the current document
in the code completion (commit https://phabricator.kde.org/R32:f14a8fc9ceb38a91c2d718552779da666d509bf1 from July 2017 [!!!]) the
unit tests where failing. The reason was that clang only saw empty
file contents when the code completion context was created with
no text. Previously, this used to fall-back to the actual file
on-disk. Nowadays, this fallback does not exist anymore, thus we
always have to pass the text in the unit tests. Do this and cleanup
the code by sharing more code in functions.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D9723
AFFECTED FILES
plugins/clang/tests/test_codecompletion.cpp
To: mwolff, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180108/2f67fc06/attachment.html>
More information about the KDevelop-devel
mailing list