D9624: Install parser headers and cmake config files to support client packages

Heinz Wiesinger noreply at phabricator.kde.org
Sat Jan 6 20:03:40 UTC 2018


pprkut added a comment.


  Not really a cmake expert. Changes look sound, but can't really judge whether they are correct. Generally looks fine to me, apart from installing the php.g grammar file.

INLINE COMMENTS

> CMakeLists.txt:49
> +    parsesession.h
> +    php.g
> +    phplexer.h

Seems a bit odd to me to install the grammar file. Afaics phpparser.h is generated from it and should have everything one needs, no?

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D9624

To: habacker, pprkut, kfunk, mtijink
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180106/dd83d8b3/attachment.html>


More information about the KDevelop-devel mailing list