D9297: Fix #387391: Random responses from the C/C++ language support

Milian Wolff noreply at phabricator.kde.org
Fri Jan 5 12:57:31 UTC 2018

mwolff added a comment.

  can you turn the test projects into proper unit tests that can be run in an automated fashion to see what happens here?
  also the `absoluteFilePath` call in kdev-clang is only used for the (undocumented) `.kdev_pch_include` feature - so that is unrelated. It should indeed probably use the canonical file path though. Anyhow, since this is clearly unrelated to what you are trying to fix, I wonder if your change actually helps? Is it maybe the call to `absoluteFilePath` in `plugins/custom-definesandincludes/noprojectincludesanddefines/noprojectincludesanddefinesmanager.cpp`'s `NoProjectIncludePathsManager::findConfigurationFile` that should be turned into a canonical path?
  In general, it might be a good idea to go through our code base and replace all calls of `absoluteFilePath` with their canonical equivalents... But let's not do that blindly, rather on a case-by-case study.

  R32 KDevelop


To: vbspam, #kdevelop
Cc: mwolff, brauch, kdevelop-devel, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180105/fe6d5433/attachment.html>

More information about the KDevelop-devel mailing list