D17679: CMake: skip server entries without empty build system information

[Milian Wolff]

mwolff created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  In one of my work projects, the CMake 3.13.1 server gave fileGroups
  responses without any useful CMakeFile data. This then was stored
  in our lookup hash used by CMakeManager::fileInformation.
  
  Then later, when we queried for these files, we found a match,
  albeit empty, and returned that leading to completely broken C++
  language support.
  
  To prevent this issue, we now skip useless empty CMakeFile entries.
  This fixes the specific scenario I'm seeing in my work project.

REPOSITORY
  R32 KDevelop

BRANCH
  5.3

REVISION DETAIL
  https://phabricator.kde.org/D17679

AFFECTED FILES
  plugins/cmake/cmakeprojectdata.h
  plugins/cmake/cmakeserverimportjob.cpp

To: mwolff
Cc: kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181219/495f50c1/attachment.html>