D16484: Add scratchpad plugin

[Amish Naidu]

amhndu added inline comments.

INLINE COMMENTS

> kfunk wrote in scratchpad.cpp:136
> Hey Amhndu.
> 
> Sorry for replying late, but I've been busy last week.
> 
> I agree that the source you're citing very much is in contrast to what I was saying. I'm trying to keep this short, but in the Qt world a `const` method implies that the function call has *no side-effects*. Here we're giving out a non-const pointer to an internal implementation detail (which the caller can then freely modify), but that is of no concern to us. We're only concerned about whether `this` is modified by that function call.
> 
> Maybe the best explanation you can find is this one here: https://wiki.qt.io/API_Design_Principles#Constness (see section "Return values: pointers vs. const pointers")

Understood.
Should I then push after fixing this ?

REPOSITORY
  R32 KDevelop

BRANCH
  scratchpad

REVISION DETAIL
  https://phabricator.kde.org/D16484

To: amhndu, #kdevelop, kfunk
Cc: kfunk, gregormi, brauch, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181210/db3769a3/attachment-0001.html>