D16484: Add scratchpad plugin
noreply at phabricator.kde.org
Mon Dec 10 09:27:47 GMT 2018
amhndu added inline comments.
> kfunk wrote in scratchpad.cpp:136
> Hey Amhndu.
> Sorry for replying late, but I've been busy last week.
> I agree that the source you're citing very much is in contrast to what I was saying. I'm trying to keep this short, but in the Qt world a `const` method implies that the function call has *no side-effects*. Here we're giving out a non-const pointer to an internal implementation detail (which the caller can then freely modify), but that is of no concern to us. We're only concerned about whether `this` is modified by that function call.
> Maybe the best explanation you can find is this one here: https://wiki.qt.io/API_Design_Principles#Constness (see section "Return values: pointers vs. const pointers")
Should I then push after fixing this ?
To: amhndu, #kdevelop, kfunk
Cc: kfunk, gregormi, brauch, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel