D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots
René J.V. Bertin
noreply at phabricator.kde.org
Sun Dec 9 22:06:03 GMT 2018
rjvbb created this revision.
rjvbb added a reviewer: KDevelop.
rjvbb added a project: KDevelop.
rjvbb requested review of this revision.
This adds 2 missing slots to the KTextEditorPlugin integration layer: `MainWindow::openUrl()` and `MainWindow::showToolView()`.
See D16779 <https://phabricator.kde.org/D16779>
Works as intended on Mac and Linux.
I'm not entirely convinced about `showToolView()`. It works as long as the toolview in question hasn't been removed from and then re-added to the dock area, but the toolview itself isn't necessarily usable (the one from the CTags plugin isn't).
I've considered making the slot a stub that simply returns false, but wanted to present a working alternative first.
To: rjvbb, #kdevelop
Cc: kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel