D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots

René J.V. Bertin noreply at phabricator.kde.org
Sun Dec 9 22:06:03 GMT 2018


rjvbb created this revision.
rjvbb added a reviewer: KDevelop.
rjvbb added a project: KDevelop.
rjvbb requested review of this revision.

REVISION SUMMARY
  This adds 2 missing slots to the KTextEditorPlugin integration layer: `MainWindow::openUrl()` and `MainWindow::showToolView()`.
  
  See D16779 <https://phabricator.kde.org/D16779>

TEST PLAN
  Works as intended on Mac and Linux.
  
  I'm not entirely convinced about `showToolView()`. It works as long as the toolview in question hasn't been removed from and then re-added  to the dock area, but the toolview itself isn't necessarily usable (the one from the CTags plugin isn't).
  I've considered making the slot a stub that simply returns false, but wanted to present a working alternative first.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17465

AFFECTED FILES
  kdevplatform/shell/ktexteditorpluginintegration.cpp
  kdevplatform/shell/ktexteditorpluginintegration.h

To: rjvbb, #kdevelop
Cc: kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181209/1b80d48f/attachment.html>


More information about the KDevelop-devel mailing list