D17424: KDevelop/PatchReview: polish Purpose integration

René J.V. Bertin noreply at phabricator.kde.org
Sat Dec 8 09:10:24 GMT 2018


rjvbb created this revision.
rjvbb added a reviewer: apol.
rjvbb added a project: KDevelop.
rjvbb requested review of this revision.

REVISION SUMMARY
  This makes 2 minor changes to the integration with the Purpose framework:
  
  - sets appropriate initial values to the "Export" model parameters `urls` and `mimeType` to avoid startup warnings `Cannot initialize model with data QJsonObject() . missing: QJsonValue(string, "urls")`
  - sets the `updateComment` of the Phabricator plugin so that the default upgrade summary is a little more personal.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17424

AFFECTED FILES
  plugins/patchreview/patchreviewtoolview.cpp

To: rjvbb, apol
Cc: kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181208/f9ae46bc/attachment.html>


More information about the KDevelop-devel mailing list