D16484: Add scratchpad plugin

Kevin Funk noreply at phabricator.kde.org
Mon Dec 3 20:11:16 GMT 2018


kfunk accepted this revision.
kfunk added inline comments.

INLINE COMMENTS

> amhndu wrote in scratchpad.cpp:136
> Needs to be mutable because http://doc.qt.io/qt-5/qsortfilterproxymodel.html#setSourceModel, used in scratchpadview.cpp:101

Heh, sorry, misunderstanding. The method should be const, not the return-type.

> amhndu wrote in scratchpadjob.cpp:99
> see line 94 right above, can't be const

Dito

REPOSITORY
  R32 KDevelop

BRANCH
  scratchpad

REVISION DETAIL
  https://phabricator.kde.org/D16484

To: amhndu, #kdevelop, kfunk
Cc: kfunk, gregormi, brauch, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181203/a2b1157b/attachment.html>


More information about the KDevelop-devel mailing list