D17255: KDevelop: support for installing into a non-standard parallel prefix

[Kevin Funk]

kfunk added a subscriber: apol.
kfunk added a comment.


  > I've tested the idea of NOT specifying an install prefix default when none has been configured. To the best I can see this does not lead to invalid cmake invocations (aka -DCMAKE_INSTALL_PREFIX=). Instead, this does exactly what you'd expect: cmake will use whatever is its default for the current platform. The result will be obtained from the CMakeCache later on.
  >  In other words, there doesn't appear to be any reason to hardcode assumptions about CMake's defaults, and not doing that should be a suitable compromise for everyone. It also removes the need for conditional code.
  
  @apol Do you think that makes sense?

INLINE COMMENTS

> manpageplugin.cpp:98
> +    if (!dec->topContext()->url().str().startsWith(QLatin1String("/usr/"))
> +            && !dec->topContext()->url().str().startsWith(QLatin1String(KDEVELOP_INSTALL_PREFIX)))
>          return {};

I wonder if we just want to remove that complete if-branch altogether... Not entirely sure what it is trying to work-around.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17255

To: rjvbb, #kdevelop, kfunk
Cc: apol, flherne, kfunk, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181202/9344bde6/attachment.html>