D17278: Meson plugin: First working version

[Francis Herne]

flherne added inline comments.

INLINE COMMENTS

> mesonbuilder.cpp:150
> +            i18n("The directory '%1' is not empty and does not seem to be an already configured build directory",
> +                 buildDir.buildDir.toLocalFile()));
> +    case INVALID_BUILD_DIR:

This condition is reached in case a previous configure attempt failed, e.g. because of a missing dependency.

KDevelop refuses to re-try the configure step (after installing the dependency) until the build dir is removed, which is quite inconvenient.

> mesonbuilder.cpp:46
> +        , m_error(error)
> +    {
> +    }

This needs `setStandardToolView(KDevelop::IOutputView::BuildView);` or similar, otherwise the output appears as a separate view with no name or icon.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17278

To: dmensinger, apol
Cc: flherne, rizzitello, yurchor, kde-doc-english, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181201/7790c1e8/attachment.html>