D17278: Meson plugin: First working version

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> kdevmesonmanager.json:5
> +        "Description": "Imports and edits Meson projects",
> +        "Description[ca at valencia]": "Importa i edita projectes del Meson",
> +        "Description[ca]": "Importa i edita projectes del Meson",

There is no need to add translations. They will be removed by scripty then renewed after the translator review anyway.

> mesonbuilder.cpp:150
> +            this,
> +            i18n("The directory '%1' is not empty and does not seam to be an already configured build directory",
> +                 buildDir.buildDir.toLocalFile()));

Typo: seam -> seem

> mesonbuilder.cpp:155
> +            this,
> +            i18n("The directory '%1' can not be used as a meson build directory", buildDir.buildDir.toLocalFile()));
> +    case EMPTY_STRING:

Typo: can not -> cannot

> mesonconfigpage.ui:122
> +            <property name="text">
> +             <string>TODO -- Implement in seperate UI file</string>
> +            </property>

Typo: seperate -> separate

> mesonnewbuilddir.cpp:169
> +    case MesonBuilder::INVALID_BUILD_DIR:
> +        setStatus(i18n("Can not use specified directory"), false);
> +        break;

Typo: Can not -> cannot

https://en.oxforddictionaries.com/usage/cannot-or-can-not

> mesonnewbuilddir.cpp:187
> +    if (!m_configIsValid) {
> +        qCDebug(KDEV_Meson) << "Can not generate build dir config from invalid config";
> +        return buildDir;

Typo: can not -> cannot

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D17278

To: dmensinger, apol
Cc: yurchor, kde-doc-english, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181201/c7eb7926/attachment.html>