D17255: KDevelop: support for installing into a non-standard parallel prefix

[René J.V. Bertin]

rjvbb updated this revision to Diff 46601.
rjvbb added a comment.


  The python script changes were committed to the master branch as requested (db05710cb6931a7b44d7fc70bfcfe75c7ccc9f4a <https://phabricator.kde.org/R32:db05710cb6931a7b44d7fc70bfcfe75c7ccc9f4a>).
  
  I've removed the change to the cmake executable lookup; I'll keep it as a distribution patch.
  
  I've tested the idea of NOT specifying an install prefix default when none has been configured. To the best I can see this does not lead to invalid cmake invocations (aka `-DCMAKE_INSTALL_PREFIX=`). Instead, this does exactly what you'd expect: cmake will use whatever is its default for the current platform. The result will be obtained from the `CMakeCache` later on.
  In other words, there doesn't appear to be any reason to hardcode assumptions about CMake's defaults, and not doing that should be a suitable compromise for everyone. It also removes the need for conditional code.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17255?vs=46546&id=46601

REVISION DETAIL
  https://phabricator.kde.org/D17255

AFFECTED FILES
  config-kdevelop.h.cmake
  plugins/cmake/cmakeutils.cpp
  plugins/cmake/cmakeutils.h
  plugins/manpage/manpageplugin.cpp

To: rjvbb, #kdevelop, kfunk
Cc: flherne, kfunk, kdevelop-devel, glebaccon, hase, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20181201/45a1a8d3/attachment.html>