D14931: Eliminate duplicate QMaps in OutputWidget

[Kevin Funk]

kfunk added a comment.


  Note: In general this patch looks good to me.

INLINE COMMENTS

> outputwidget.cpp:278
>              }
> -            delete view;
> -        } else
> -        {
> -            m_views.value( id )->setModel( nullptr );
> -            m_views.value( id )->setItemDelegate( nullptr );
> -            if( m_proxyModels.contains( 0 ) ) {
> -                delete m_proxyModels.take( 0 );
> -                m_filters.remove( 0 );
> +            m_views.remove(id);
> +        } else {  // KDevelop::IOutputView::OneView

I think this line is redundant. You're doing `m_views.remove(id);` outside the if-else stmt anyway(?)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14931

To: vkorneev, #kdevelop
Cc: kfunk, pino, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180823/0c0fdb4c/attachment.html>