D14996: Fix clazy 'connect-3arg-lambda' warnings
noreply at phabricator.kde.org
Wed Aug 22 13:40:34 BST 2018
kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.
> KF5_VERSION=v5.48.0 # note: v5.49.0 is broken due to https://phabricator.kde.org/R246:0a96acf251baa5c9dd042d093ab2bf8fcee10502
> -KDE_PLASMA_VERSION=v5.13.4 # note: need libksysguard commit a0e69617442d720c76da5ebe3323e7a977929db4 (patch which makes plasma dep optional)
> +KDE_PLASMA_VERSION=v5.13.3 # note: need libksysguard commit a0e69617442d720c76da5ebe3323e7a977929db4 (patch which makes plasma dep optional)
Unrelated. I guess wrong arc usage? :)
> antonanikin wrote in midebugsession.cpp:559
> Although I was wrong, sorry - we can (and should) use `this` here. Will update the revision.
Yes, I think like this it should work. The `QPointer` was needed when `QTimer::singleShot`didn't allow context objects (before Qt 5.4 iirc).
To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel