D14958: Fix kdev_perforce unittest to run on kde windows CI and everywhere else.

Morten Volden noreply at phabricator.kde.org
Tue Aug 21 13:56:07 BST 2018


volden added inline comments.

INLINE COMMENTS

> kfunk wrote in test_perforce.cpp:58
> Use `http://doc.qt.io/qt-5/qstandardpaths.html#findExecutable`? Also `QVERIFY(...)` that the executable was found maybe?

As far as I can tell. findExecutable is not recursive. So I would still need QDirIterator to find the dirs for findExecutable to look through. So the question is how much more sense findExecutable makes in this scenario?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14958

To: volden, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180821/201b574d/attachment-0001.html>


More information about the KDevelop-devel mailing list