D14931: Eliminate duplicate QMaps in OutputWidget

[Vyacheslav Korneev]

vkorneev created this revision.
Herald added a project: KDevelop.
Herald added a subscriber: kdevelop-devel.
vkorneev requested review of this revision.

REVISION SUMMARY
  There were 3 QMaps with identical keys used for storing corresponding
  view, proxy model and filter. In this version only one map is used - this
  reduces the amount of map lookups and potential mistakes during code
  changes.

TEST PLAN
  This patch isn't supposed to change any behavior in OutputWidget, so we
  need to assure that OutputWidget works as usually. For example:
  create a few outputs;
  enter the filters for some of the outputs;
  choose random output;
  close all other outputs;
  check if the output is shown, filter corresponds to output, etc;
  repeat previous actions a few times.

REPOSITORY
  R32 KDevelop

BRANCH
  refactor_outputwidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14931

AFFECTED FILES
  plugins/standardoutputview/outputwidget.cpp
  plugins/standardoutputview/outputwidget.h
  plugins/standardoutputview/tests/test_standardoutputview.cpp

To: vkorneev
Cc: kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180819/1fd29d42/attachment-0001.html>