D14710: Inject default environment group variables into debug process environment.

[Raúl Sánchez Siles]

Kebianizao added a comment.


  In D14710#309820 <https://phabricator.kde.org/D14710#309820>, @brauch wrote:
  
  > I'm actually fine with this approach, I just don't understand why the environment is set once on the process and once on the job. Why is this necessary, or do I misunderstand what it's doing ...?
  
  
  I'm reviewing this right now. I don't have a reasonable answer for your question. As the patch was my first working version, I think I only managed to get the environmentProfiles variables at PdbLauncher::start not noticing that I could get the variables from a specific environment profile anywhere like this:
  
    const KDevelop::EnvironmentProfileList environmentProfiles(KSharedConfig::openConfig());
  
  Later I though that I could just simply store the environment profile name at PdbLauncher::start, include it in the DebugJob object and tweak the debugee process environment just before the debug process is created at DebugSession::start.
  Final patch will arrive in short.

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D14710

To: Kebianizao, #kdevelop
Cc: brauch, vkorneev, apol, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180815/3e3e6eda/attachment.html>