D14750: Fix problems with output filters in StandardOutputView plugin
noreply at phabricator.kde.org
Wed Aug 15 10:06:01 BST 2018
kfunk added a comment.
In D14750#306789 <https://phabricator.kde.org/D14750#306789>, @vkorneev wrote:
> If these changes pass the review, I'd like to also make a little refactoring to this code consisting of using one QMap with structs containing pointers to corresponding view, filter and proxy model instead of 3 QMaps with the same keys in current code. Did I get it right that I should do these changes in separate patch?
Yes, separate patch. And I like your idea of putting this into one map instead! The code as-is is difficult to understand.
To: vkorneev, #kdevelop, brauch
Cc: kfunk, brauch, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel