D14479: Store sizeof and friends as numbers instead of comment.
noreply at phabricator.kde.org
Mon Aug 13 16:20:28 BST 2018
michalsrb added inline comments.
> brauch wrote in classmemberdeclaration.h:75
> this comment is wrong, it returns the size, not the alignment
copy paste mistake, I will fix that
> brauch wrote in classmemberdeclaration.h:77
> Why is this a 64-bit integer? I.e. why is 32-bit not sufficient?
I chose that because that is what `clang_Type_getSizeOf` returns. You can declare something like `char c[0x100000000]` and it will display the size properly.
But I expect that almost no real code will have sizes or offsets this big, so we could use 32-bit integer instead and fallback to -1 for the extreme cases. Do you think we should?
To: michalsrb, #kdevelop, aaronpuchert
Cc: brauch, aaronpuchert, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel