D14791: Fix assert in ClassModel::nodesRemoved
Bernd Buschinski
noreply at phabricator.kde.org
Mon Aug 13 14:38:02 BST 2018
buschinski created this revision.
Restricted Application added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.
buschinski requested review of this revision.
REVISION SUMMARY
This Patch fixes https://bugs.kde.org/show_bug.cgi?id=396347 .
Previously "nodesRemoved" included the begin&end notification for removing rows, without removing any in between.
The patch changes the logic to correctly announce the begin before removing rows and the end after the rows have been removed.
TEST PLAN
- build Qt 5.11.1 with debug&assert enabled
- recompile kdevelop against this version of Qt
- start kdevelop
- open the Classes Toolview
- close kdevelop
-> crash/assert
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D14791
AFFECTED FILES
kdevplatform/language/classmodel/classmodel.cpp
kdevplatform/language/classmodel/classmodel.h
kdevplatform/language/classmodel/classmodelnode.cpp
To: buschinski
Cc: kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180813/104c36fe/attachment.html>
More information about the KDevelop-devel
mailing list