D14694: Consistently use icon for "Analyze [...] With" submenus

[Aaron Puchert]

aaronpuchert added a comment.


  Maybe this has been discussed before, but I think something like a magnifying glass (`search`) would be more appropriate. The check mark suggests that the code is "verified", in the sense that it's definitely fine, but most (all?) static analysis tools don't guarantee that. If the tool finds something, then something is probably wrong, but if it doesn't, there could still be a mistake.
  
  The tools also get better, adding more checks, which means that there might be no issues with some code first, but on updating the analysis tool new issues appear. Then it's weird to have the check mark, because once "it worked" and now "it doesn't". With the magnifying glass it's clear that we search for issues, and with new versions of our tool we might find more.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D14694

To: kossebau, #kdevelop
Cc: aaronpuchert, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180808/f5cc7284/attachment.html>