D14304: Use "edit-delete" icon for buttons which delete data

Aaron Puchert noreply at phabricator.kde.org
Tue Aug 7 00:01:04 BST 2018


aaronpuchert added a comment.


  In D14304#304677 <https://phabricator.kde.org/D14304#304677>, @kossebau wrote:
  
  > In the case of the include path removing a path entry does not feel like one is deleting data, as the string is an existing dir (at least usually). So it is more like adding & removing existing items (the paths) to and from a list.
  
  
  That makes sense, although similar reasoning could apply to the project filter. But I think your change is Ok in that regard. It's really hard to draw the line.

REPOSITORY
  R32 KDevelop

BRANCH
  useeditdeleteicon

REVISION DETAIL
  https://phabricator.kde.org/D14304

To: kossebau, #kdevelop, aaronpuchert
Cc: aaronpuchert, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180806/92295bce/attachment.html>


More information about the KDevelop-devel mailing list