D14479: Store sizeof and friends as numbers instead of comment.

Aaron Puchert noreply at phabricator.kde.org
Mon Aug 6 23:11:31 BST 2018

aaronpuchert added a comment.

  Nice. Having this information better structured and accessible is definitely a good thing!


> classmemberdeclaration.cpp:32-34
> +    , m_sizeOf(-1)
> +    , m_bitOffsetOf(-1)
> +    , m_alignOf(-1)

Maybe you should document somewhere that -1 means that no information is available.

> classmemberdeclarationdata.h:40
> +  int64_t m_bitOffsetOf;
> +  int64_t m_alignOf;
>    bool m_isStatic: 1;

If we want to reduce the storage space required,  we could use that alignment is always a power of two and only store the exponent. Since int64_t can store values up to 2^63-1, we need 6 bits for the exponent.

  R32 KDevelop


To: michalsrb, #kdevelop
Cc: aaronpuchert, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180806/b93aac39/attachment-0001.html>

More information about the KDevelop-devel mailing list