D13580: Add support for Generators.

Heinz Wiesinger noreply at phabricator.kde.org
Thu Aug 2 19:33:11 BST 2018


pprkut marked an inline comment as done.
pprkut added inline comments.

INLINE COMMENTS

> zhigalin wrote in phplexer.cpp:810-811
> This smells like spaghetti, are you sure? how about something like
> 
>   auto nextToken = QString();
>   nextToken += *   lookAhead;
>   nextToken += * ++lookAhead;
>   nextToken += * ++lookAhead;
>   nextToken += * ++lookAhead;
>   if (pos + 1 < m_contentSize && nextToken == QStringLiteral("from")) {
> 
> //(example code, not sure it will work)//

Minor adjustments, but it seems to work. Thanks! :)

REPOSITORY
  R52 KDevelop: PHP Support

BRANCH
  generators

REVISION DETAIL
  https://phabricator.kde.org/D13580

To: pprkut, zhigalin
Cc: zhigalin, mwolff, kfunk, brauch, kdevelop-devel, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180802/6721c49a/attachment.html>


More information about the KDevelop-devel mailing list