D12298: Group completion requests and only handle the last one

[Milian Wolff]

mwolff added a comment.


  ok let's see

INLINE COMMENTS

> brauch wrote in model.cpp:90
> Can you not use QMetaObject::invokeMethod(this, &ClangCodeCompletionWorker::run, Qt::QueuedConnection) instead of this timer? (The function pointer syntax is Qt 5.10+ though I think)

yes, but as you say it's 5.10 - this code here is fine and a bit better than using QTimer::singleShot since that would recreate the timer continously

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D12298

To: mwolff, #kdevelop
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180418/56cfd7c9/attachment.html>