D12298: Group completion requests and only handle the last one

Sven Brauch noreply at phabricator.kde.org
Wed Apr 18 07:16:42 UTC 2018


brauch added a comment.


  I think the change makes sense, I applied the patch here, let's see how it goes.

INLINE COMMENTS

> model.cpp:90
> +
> +        if (!m_timer) {
> +            // lazy-load the timer to initialize it in the background thread

Can you not use QMetaObject::invokeMethod(this, &ClangCodeCompletionWorker::run, Qt::QueuedConnection) instead of this timer? (The function pointer syntax is Qt 5.10+ though I think)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D12298

To: mwolff
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180418/d78bdaa8/attachment.html>


More information about the KDevelop-devel mailing list