D12279: shell: Display generic project managers again

[Friedrich W. H. Kossebau]

kossebau added a comment.


  My bad, can see how this broke.
  
  Not tested the patch yet, just executed mentally and LGTM as well, besides the issue mentioned. Will have a closer look tonight.

INLINE COMMENTS

> openprojectdialog.cpp:104
>          if (filter.isEmpty()) {
> +            m_genericProjectPlugins << info.name();
>              continue;

Isn't this still missing to add the plugininfo to m_projectPlugins?

Adding that would be something that should always be done, and thus be before this if-else.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D12279

To: mschwarz, #kdevelop, mwolff
Cc: mwolff, kossebau, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180417/4da0d9d0/attachment.html>