D11912: Avoid emptry entries in project files filter list
Max Schwarz
noreply at phabricator.kde.org
Tue Apr 17 10:22:00 UTC 2018
mschwarz added a comment.
I think this may prevent KDevGenericManager from being selectable at all. Later in `OpenProjectDialog::validateOpenUrl()` we check for empty filters to add plugins that do not need a specific file:
Q_FOREACH ( const auto& plugin, m_projectFilters.keys() ) {
qCDebug(SHELL) << plugin << m_projectFilters.value(plugin);
if ( m_projectFilters.value(plugin).isEmpty() ) {
// that works in any case
auto meta = m_projectPlugins.value(plugin);
choices.append({plugin, meta.pluginId(), meta.iconName()});
}
}
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D11912
To: kossebau, #kdevelop, mwolff
Cc: mschwarz, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180417/2cd4ee04/attachment.html>
More information about the KDevelop-devel
mailing list