D11933: Only do fuzzy path matching on the very last path/filter segments
Milian Wolff
noreply at phabricator.kde.org
Wed Apr 4 20:19:30 UTC 2018
mwolff created this revision.
Restricted Application added a subscriber: kdevelop-devel.
mwolff requested review of this revision.
REVISION SUMMARY
The old code joined all filter segments and then used that to match
it against the last path segment. This is quite odd behavior, imo:
If I type "foo/bar", then I wouldn't expect it to match a file called
"fooXbar". On the other hand, I would expect "foo/bar" to fuzzy-match
"foo/xBxAxRx", since the "foo" segment is matched and then "bar" is
fuzzy-matched against the "xBxAxRx" segment.
The new tests fuzzy2, fuzzy3 and fuzzy5 fail with the old code but
pass with the new, simplified code.
REPOSITORY
R32 KDevelop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11933
AFFECTED FILES
kdevplatform/language/interfaces/abbreviations.cpp
kdevplatform/language/interfaces/abbreviations.h
kdevplatform/language/interfaces/quickopenfilter.h
plugins/quickopen/tests/test_quickopen.cpp
To: mwolff
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180404/5c3094ce/attachment-0001.html>
More information about the KDevelop-devel
mailing list