D7995: KDevelop: address dirwatching inefficiency (WIP/PoC)

Milian Wolff noreply at phabricator.kde.org
Thu Sep 28 15:53:18 UTC 2017


mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  Can you please put the benchmark into a separate review as I requested? It must be self-contained, the "do stuff in background" change should then depend on that revision.

INLINE COMMENTS

> abstractfilemanagerplugin.cpp:123
> +    QElapsedTimer timer;
> +    if (m_watchers.contains(project)) {
> +        timer.start();

you removed the wrong conditional - I added the comment to this line, the if for the `m_watchers.contains()` - this should be removed, _not_ the `#ifdef` for the actual timing feature (that should remain optional)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7995

To: rjvbb, #kdevelop, mwolff
Cc: aaronpuchert, arrowdodger, kfunk, dfaure, mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170928/282f4990/attachment-0001.html>


More information about the KDevelop-devel mailing list