D7979: Filter out warnings as error from parser's compile flags

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  more nits, sorry :P

INLINE COMMENTS

> parsesession.cpp:68
>  
> +void sanitizeArguments(QVector<QByteArray>& arguments)
> +{

please add a comment here as I requested the last time

> parsesession.cpp:72
> +        arguments.begin(), arguments.end(),
> +        [](QByteArray& argument) {
> +            if (argument == "-Werror") {

hmmm I like the brevity of this code, I'm not too sure what others think. mutating from within a remove_if callback? Haven't seen this before, but it should work so let's keep it this way. please do add a comment here though.

> parsesession.cpp:77
> +
> +            QByteArray asError = "-Werror=";
> +            int index = argument.indexOf(asError);

use QByteArrayLiteral:

  const auto asError = QByteArrayLiteral("-Werror=");

> parsesession.cpp:79
> +            int index = argument.indexOf(asError);
> +
> +            if (index == 0) {

remove empty line

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D7979

To: gracicot, #kdevelop, kfunk, mwolff, brauch
Cc: mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170927/06caf404/attachment.html>