D7979: Filter out warnings as error from parser's compile flags
Guillaume Racicot
noreply at phabricator.kde.org
Tue Sep 26 13:33:58 UTC 2017
gracicot added inline comments.
INLINE COMMENTS
> mwolff wrote in parsesession.cpp:116
> it's just overly complicated, imo. a plain remove_if + erase would achieve the same, without moving and without constructing a second container, thus probably being faster too (and less code!)
I was focused on returning a new, filtered container, instead of just changing the current one. Sorry, I'll fix it soon. Also, I just realized I take the container by const ref, so this `std::move` is completely ineffective indeed.
REPOSITORY
R32 KDevelop
REVISION DETAIL
https://phabricator.kde.org/D7979
To: gracicot, #kdevelop, kfunk, mwolff
Cc: mwolff, brauch, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170926/ab6ad252/attachment.html>
More information about the KDevelop-devel
mailing list